[Mailer] Fix attachment changes #18765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feymo
reviewed
Aug 18, 2023
|
Jules, thanks a lot for this thorough review of the mailer deprecations. I'm happy to know that docs are now fully precise. |
c3584a9 to
46923d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title of symfony/symfony#47711 did not change before merge, but actually only
attachParthas been deprecated (renamed) in favor ofaddPart.I did not reintroduce the other methods as they may be deprecated in 7.1, so no need to document a way that may change in a few months.
Also the
BodyFileclass has been renamed in symfony/symfony#48060 whereas the use in the example code was correct.