[Serializer] Use NormalizerInterface instead of ObjectNormalizer
#18779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serializer/custom_normalizer.rst
Outdated
|
|
||
| class TopicNormalizer implements NormalizerInterface | ||
| { | ||
| public function __construct( | ||
| private UrlGeneratorInterface $router, | ||
| private ObjectNormalizer $normalizer, | ||
| private NormalizerInterface $normalizer, |
There was a problem hiding this comment.
I think this leads to a cyclic dependency, if I remember correctly when I documented something similar 🤔 You may base yourself on those ones I think!
There was a problem hiding this comment.
Indeed, if forgot about that part, I copied the #18602 PR contents, thanks!
Btw, this is deprecated since 6.1 (and not 6.4), should we update the 6.4 branch as well?
There was a problem hiding this comment.
I'd say yes, I guess this may be managed during upmerge?
There was a problem hiding this comment.
Yes we will handle it while unmerging this PR 👍
e4c705b to
07280cd
Compare
NormalizerInterface instead of ObjectNormalizer
|
@OskarStark if you think this is ready, please merge it. I don't feel confident merging things related to the serializer. Thanks! |
OskarStark
reviewed
Oct 7, 2023
07280cd to
3e9af1b
Compare
OskarStark
approved these changes
Oct 7, 2023
|
Thank you @mtarld. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in symfony/maker-bundle#1252 (comment), the documentation is telling to use a concrete implementation of the
NormalizerInteface.This is not the best in terms of OOP, and moreover doesn't work since Symfony 6.1 and the introduction of
TraceableNormalizer.