[Configuration] env() parameters notation
#18898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Sep 20, 2023
| @@ -674,6 +674,53 @@ To define the value of an env var, you have several options: | |||
| * :ref:`Encrypt the value as a secret <configuration-secrets>`; | |||
| * Set the value as a real environment variable in your shell or your web server. | |||
|
|
|||
| It is possible to define an env var default value by defining a parameter with | |||
There was a problem hiding this comment.
WDYT to explain in which case is needed ?
The only case is see is when env var if it's not set. If we don't configure this default symfony will throw an exception, right ?
There was a problem hiding this comment.
Isn't the "if it has not been defined anywhere" part on line 679 explicit enough? If no, I can add something else indeed!
|
Thanks Alex. While merging we reworded this a bit to first explain the problem (if env var is not defined, you'll see an exception) and then the solution (define a default value for the env var). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13678
We explain above how to define a env var value, so it seems neat to put this explanation here, "if it has not been defined anywhere" 🙂