Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Fix custom form type docs #19222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

aurimasrim
Copy link
Contributor

  1. Fixes the link to the twig config reference
  2. Fixes the priority of order of twig.form_themes see https://symfony.com/doc/current/reference/configuration/twig.html#form-themes

@carsonbot carsonbot added this to the 5.4 milestone Dec 5, 2023
@OskarStark OskarStark changed the title [Form] Fix custom form type docs. [Form] Fix custom form type docs Dec 9, 2023
@OskarStark
Copy link
Contributor

@javiereguiluz maybe do you know if this is true. I am wondering, as we explicitly mention to add it to the beginning before and now it should be changed to the reverse... 🤔 I've never had more than one form_theme...

@javiereguiluz
Copy link
Member

@OskarStark you made me doubt about this 😓 Let's ask Symfony Form experts like @xabbuh or @HeahDude Thanks!

@HeahDude
Copy link
Contributor

HeahDude commented Dec 9, 2023

This is true as said in the linked documentation in the PR description.

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR!

@OskarStark
Copy link
Contributor

Thank you @aurimasrim.

@OskarStark OskarStark merged commit bb30765 into symfony:5.4 Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants