[Scheduler] Document events #19450
Merged
[Scheduler] Document events #19450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Jan 22, 2024
Comment on lines
+520
to
+522
| $schedule = $event->getSchedule(); | ||
| $context = $event->getMessageContext(); | ||
| $message = $event->getMessage(); |
There was a problem hiding this comment.
Right know, we don't explain in the scheduler documentation:
- What is a
MessageContext - What is a
Schedule(we talk about ScheduleProvider however)
There was a problem hiding this comment.
Yes, we're missing things ... but let's do that in other PRs. The idea with the Scheduler docs is to move very fast (even if that breaks some things) to compensate a bit the big delay in merging these docs. Thanks.
747b47e to
445075c
Compare
|
Thanks Antoine! I'm glad to merge as many PRs as possible about the scheduler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19023
Fix #19033