[Emoji][Twig] Add emojify filter
#19773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Apr 11, 2024
alamirault
reviewed
Apr 13, 2024
| ``text`` | ||
| **type**: ``string`` | ||
|
|
||
| ``catalog`` *(optional)* |
There was a problem hiding this comment.
When is null, default extension catalog is applied. It's "text" by default in construct.
I don't remember what is text behavior, but we should discribe this default ?
There was a problem hiding this comment.
text locale must be documented first #19745
| .. code-block:: twig | ||
|
|
||
| {{ ':+1:'|emojify }} {# renders: 👍 #} | ||
| {{ ':+1:'|emojify('github') }} {# renders: 👍 #} |
There was a problem hiding this comment.
What is the rendering of an unknown value for the catalog ?
Adding an example could be great !
|
Friendly ping @javiereguiluz |
|
I rebased and added more examples. |
xabbuh
approved these changes
Jun 17, 2024
emojify filter
alamirault
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19756.
@lyrixx if you can, please review this. Thanks!