Changing description of autoloading to "The composer way" #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only include minor changes.
|
|
||
| A bundle can live *anywhere* as long as it can be autoloaded (via the | ||
| autoloader configured at ``app/autoload.php``). | ||
|
|
|
I reverted the changes. I am sorry for the inconvenience as some changes were really wrong. I was under the impression that the app/autoload.php should remain unchanged and composer should be used in any case to load all files. |
|
@Sgoettschkes app/autoload.php can be changed if you need to add some custom stuff (like the intl fallback registered in the SE). But you will generally not need to configure custom stuff by hand |
| @@ -22,8 +22,7 @@ on top of the previous one. | |||
| .. tip:: | |||
|
|
|||
| Autoloading is not managed by the framework directly; it's done by using | |||
| Composer's autoloader (``vendor/autoload.php``), which is included in | |||
| the ``src/autoload.php`` file. | |||
There was a problem hiding this comment.
This is still true (except that src/autoload.php doesn't exists, it should be app/autoload.php)
weaverryan
added a commit
that referenced
this pull request
Dec 16, 2012
Changing description of autoloading to "The composer way"
|
Another great one Sebastian, and another closed issue - thanks! |
weaverryan
added a commit
that referenced
this pull request
Dec 16, 2012
This was referenced Mar 19, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @weaverryan in #1176, there are some mentioned of the old
app/autoload.php. I searched for those and replaced them with the correctvendor/autoload.php.The two bigger changes including some more description of Composer and how it all works together. Both files are suggestions and I am happy to change them according to your feedback.