[Reference/Validation Constraints] Add some missing xml reference examples. #2027
Conversation
l3l0
commented
Dec 15, 2012
- Added missing xml examples for: Blank, Length, NotBlank, NotNull, Null
- Fix MinLength xml example
…eference [Reference/Validation Constraints] Add some missing xml reference examples.
|
Hi Leszek! Ah, this is great man! You can see that we don't have enough people looking at our XML examples, so thanks so much for doing this. I was also able to backport most of these changes to the 2.0 branch as well. Thanks! |
|
👍 for this, it was on my todo list to do in 2013. @weaverryan there are some other formats missing as well in code examples, it is maybe an idea to index where which format is missing to get someone looking at it? |
|
@wouterj that would be kind of fun :), someone just needs to write it (i.e. parse through the files for these blocks to see which are missing). Then we could at least run that little script from time-to-time to figure out where we're missing things. Going forward, we would ideally not merge anything without all formats, but in reality, some formats aren't used as much, so I tend to like to merge more quickly and add those other formats later. If we could get a quick list of missing places, that would certainly be cool! |
|
@weaverryan ok, I'm on it! 🚂 |