Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bootstrapped article about removing bundles (especially the AcmeDemoBundle) #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Dec 28, 2012

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

This cookbook article explains how to savely remove a bundle from your application and it takes the AcmeDemoBundle as an example.

This is discussed a couple times (symfony/symfony#1309 and symfony/symfony-standard#412). The conclusions of those discussions where to create "clear instructions on how to remove the Acme demo code by hand." and not do it automatically, it will get to complicated.

I will squash the commits together if it get merged, but first I want to hear what I should improve :)

@gajdaw
Copy link
Contributor

gajdaw commented Jan 2, 2013

Isn't it the exact copy of 4) Getting started with Symfony?

https://github.com/symfony/symfony-standard

@wouterj
Copy link
Member Author

wouterj commented Jan 2, 2013

I think it is a good idea to have this in the documentation, because it is easier to find (I think) and it we can refer to it if someone has questions about removing a bundle (not acme).

@@ -0,0 +1,123 @@
.. index::
single: Bundle; Removing AcmeDemo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AcmeDemoBundle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@weaverryan
Copy link
Member

Hey @wouterj!

I think this is a great idea, especially since having its own document makes it more "findable" and we can go into more detail here. After we merge, we may even do a PR against symfony/symfony-standard to include just a link to this document, so that we aren't maintaining it in 2 places.

Thanks!

@wouterj
Copy link
Member Author

wouterj commented Jan 25, 2013

@weaverryan I have added 2 more interlinks and I think it is ready for merge now. I have fixed al your comments, except this one. Can you merge it or convince me why the order should change?

weaverryan added a commit that referenced this pull request Jan 27, 2013
Bootstrapped article about removing bundles (especially the AcmeDemoBundle)
@weaverryan weaverryan merged commit e8b599b into symfony:2.0 Jan 27, 2013
weaverryan added a commit that referenced this pull request Jan 27, 2013
Biggest change was to rearrange steps so that all of the required steps are first, and the optional step (which doesn't apply to AcmeDemoBundle) is last.
@weaverryan
Copy link
Member

Hi Wouter!

Awesome, merged! I made some small tweaks, which you'll see. If you see any mistakes I've made, let me know like always :).

We can now also propose a change to the README on symfony/symfony-standard to link to this doc. Fabien may or may not agree with linking externally, but it's worth a try :).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants