Update framework.rst #20852
Closed
Update framework.rst #20852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs correction
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
MrYamous
reviewed
Apr 4, 2025
xabbuh
approved these changes
May 5, 2025
xabbuh
reviewed
May 5, 2025
| @@ -1239,7 +1239,7 @@ http_cache | |||
| allow_reload | |||
| ............ | |||
|
|
|||
| **type**: ``string`` | |||
| **type**: ``boolean`` **default**: ``false`` | |||
There was a problem hiding this comment.
strictly spoken, the default value is null but that in turn is treated as false in the HttpCache class
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
May 6, 2025
This PR was submitted for the 7.2 branch but it was merged into the 6.4 branch instead. Discussion ---------- Update framework.rst Docs correction <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `7.x` for features of unreleased versions). --> Commits ------- ca92b57 Update framework.rst
|
Thanks Ruben ... and congrats on your first Symfony Docs contribution 🎉 |
|
this was merged in 6e0d1c3 even though the PR is displayed as closed (that's because we merged it into a different branch than you targetted with your PR) |
OskarStark
added a commit
that referenced
this pull request
May 6, 2025
…aviereguiluz) This PR was merged into the 6.4 branch. Discussion ---------- [Reference] Update the default values of some options After merging #20852 I realized that some default option values were not following the format used in most options, so let's update them. Commits ------- 5028721 [Reference] Update the default values of some options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs correction