Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] allow to unverbose all the methods in BrowserKitAssertionsTrait #21103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

vinceAmstoutz
Copy link
Contributor

Solves #21095

@carsonbot carsonbot added this to the 7.4 milestone Jun 20, 2025
@vinceAmstoutz vinceAmstoutz force-pushed the fix/21095 branch 2 times, most recently from 055859a to 72558fb Compare June 20, 2025 13:22
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I don't understand this change.

We had $verbose = true and now we repaced it by $verbose = null but in the versionadded we say that "$verbose = true" is introduced.

Also, should we mention somewhere what "verbose" option means or what it does?

Thanks!

@OskarStark OskarStark changed the title [FrameworkBundle] allow to unverbose all the methods in BrowserKitAssertionsTrait [FrameworkBundle] allow to unverbose all the methods in BrowserKitAssertionsTrait Jun 23, 2025
@vinceAmstoutz
Copy link
Contributor Author

I'm afraid I don't understand this change.

We had $verbose = true and now we repaced it by $verbose = null but in the versionadded we say that "$verbose = true" is introduced.

Also, should we mention somewhere what "verbose" option means or what it does?

Thanks!

@javiereguiluz In the latest update, I included an explanation to enhance clarity. Specifically, I clarified the purpose of $defaultVerboseMode = true; (as seen in this source) and the $verbose method parameters.

@javiereguiluz javiereguiluz merged commit 1d7a374 into symfony:7.4 Jun 25, 2025
3 checks passed
@javiereguiluz
Copy link
Member

javiereguiluz commented Jun 25, 2025

Thanks Vincent! While merging we did some tweaks to this. The versionadded directives cannot contain any real contents or explanations. This is because we remove all this when merging into a new major Symfony version.

So, we moved the contents out of the versionadded directive and added a small usage example. See fdf8824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants