[Validation] Update CardScheme #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| This option is required and represents the name of the number scheme used to | ||
| validate the credit card number. Valid values are: | ||
| validate the credit card number. It can either be a String or an Array. Valid |
There was a problem hiding this comment.
I tend to prefer validate the credit card number, it can either....
And you should lowercase string and array, otherwise you are talking about non existing String and Array classes.
|
I improved the docs as suggested by @wouterj |
weaverryan
added a commit
that referenced
this pull request
Jan 11, 2013
[Validation] Update CardScheme
|
Thanks Sebastian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CardScheme validator changed with PR symfony/symfony#6583, so I improved the docs, mentioning that it now takes a mixed parameter and also clarifying that this parameter can be either a string or an array.