[2.1][Security] Fixed typo + some enhancement #2349
Conversation
|
The 3rd commit ([Security] Fix typo in chain provider entity) is the most important. |
| entity: | ||
| name: entity | ||
| class: SecurityBundle:User | ||
| property: username |
There was a problem hiding this comment.
This is wrong. In the previous example, the first level of entity key is the name of the provider while the second level is the config for the EntityUserProvider.
The config you added here would throw an exception.
There was a problem hiding this comment.
I did not test, sorry. But I Copy/paste the same config as bellow. I should fix the in memory user provider ? (IIRC)
|
About the key |
| property: username | ||
| class: SecurityBundle:User | ||
| property: username | ||
| # same as |
There was a problem hiding this comment.
This section MUST be removed. Telling that the previous code is the same than this invalid config is totally wrong. Please don't introduce wrong documentation when your PR says "fixed typos"
There was a problem hiding this comment.
Removed. What about memory user provider ?
[2.1][Security] Fixed typo + some enhancement
|
Hey Grégoire! This is awesome - much more descriptive and accurate. This is actually generated originally from We should fix that as well. Thanks! |
|
Ok. I will submit a PR. |
|
Done in symfony/symfony#7528 |
No description provided.