[WCM][Form] adjust collection example to data-property-name attribute #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uwej711
commented
Apr 23, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#7825) |
| Applies to | n.a. |
| Fixed tickets | n.a. |
|
could you please include the pull request format? |
| which you'll replace with a unique, incrementing number (e.g. ``task[tags][3][name]``). | ||
| which you'll replace with a unique, incrementing number (e.g. ``task[tags][3][name]``). | ||
| Since you can change this placeholder with the option "prototype_name" the actual name is | ||
| provided in the ``data-prototype-name`` attribute. |
There was a problem hiding this comment.
this should be inside a .. versionadded:: 2.3 block with a slightly different rewording.
There was a problem hiding this comment.
I did the code PR against 2.2 - I will adjust this once that is merged and use the proper version then, agreed?
There was a problem hiding this comment.
well, it's a new feature so it definitely don't get into the 2.2 branch. It gets into 2.3 or 2.4
There was a problem hiding this comment.
Let's see when and where the code gets merged :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.