Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed XML examples #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2013
Merged

Fixed XML examples #2866

merged 1 commit into from
Aug 25, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 30, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

Was on my todo list for quite a long time. xabbuh pushed me to do it after his PR :)

The big deal comes in the cookbook, where a lot of namespaces and xml schema paths are wrong. But I've seen enough XML for today... 💫 😵

dbname="%database_name%"
user="%database_user%"
password="%database_password%"
>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be />

@xabbuh
Copy link
Member

xabbuh commented Jul 30, 2013

Awesome, great job! 👍

@@ -319,7 +319,11 @@ object.

<!-- Acme/TaskBundle/Resources/config/validation.xml -->
<?xml version="1.0" charset="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be encoding here ?

weaverryan added a commit that referenced this pull request Aug 25, 2013
@weaverryan weaverryan merged commit 59e8411 into symfony:2.2 Aug 25, 2013
weaverryan added a commit that referenced this pull request Aug 25, 2013
@weaverryan
Copy link
Member

Great job Wouter! Very minor tweaks at sha: 56b6b25

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants