[#2870] put back the command argument when executing a command in the Co... #3033

xabbuh · 2013-10-04T16:26:04Z

...mmandTester

Q	A
Doc fix?	yes
New docs?	no
Applies to	#2870
Fixed tickets

Documented dumpFile

Updated sidebar to use Debug component

Documented the Comparison validators

Conflicts: components/console/helpers/progresshelper.rst reference/configuration/framework.rst

@wouterj

@wouterj

[2.3] Document Crawler::html method

Conflicts: components/filesystem.rst

…nents map

[Components][Console] Fixed typos for table helper

Made the Icu component compatible with ICU 3.8

…ridge Adding lazy services documentation as of symfony/symfony#7890

Conflicts: components/yaml/introduction.rst

[WCM] Added docs for the changes proposed in symfony/symfony#8908

Documented Stopwatch Helper

[WCM] [Process] Doc for output flush methods.

document the getEncodings() method of the Request class

@xabbuh

…reas The language used by @xabbuh is actually straight from the PHPDoc, which is cool, but I don't love the wording there, and having some variety in wording might help clarification.

stof · 2013-10-05T00:41:34Z

In case the command has been retrieved from an Application, this is indeed required in 2.3 and below (but the command argument must be omitted in case you instantiate the command instance directly).

Symfony 2.4 simplified this by hiding the handling of the internal command argument inside the CommandTester.

xabbuh · 2013-10-05T07:15:38Z

Even in 2.3 this separation was not that clear. You only had to specify the command argument if the Command itself didn't require any argument. Otherwise, the first argument was treated as the command name, regardless how much sense this did make.

Thus, the new feature in 2.4 was in fact intended to fix this inconsistency.

fix versionadded directive

Fixed wrong redirection of virtuals -> inherit_data

fix build errors

Conflicts: book/forms.rst components/event_dispatcher/introduction.rst cookbook/configuration/front_controllers_and_kernel.rst cookbook/form/dynamic_form_modification.rst reference/configuration/framework.rst reference/constraints/Max.rst reference/constraints/MaxLength.rst reference/constraints/Min.rst reference/constraints/MinLength.rst reference/forms/types/choice.rst reference/forms/types/field.rst reference/forms/types/form.rst reference/forms/types/map.rst.inc

Conflicts: reference/constraints/Image.rst

… in the CommandTester

weaverryan · 2013-10-14T22:29:48Z

Thanks @xabbuh - it looks like this never should have been removed. I've patched your commit into the 2.2 branch at sha: 921a63b. Will this need to be changed in 2.4 due to symfony/symfony@50c8050?

xabbuh · 2013-10-15T05:30:48Z

Well, we can remove it again in 2.4 and add a versionadded directive.

xabbuh · 2013-10-22T15:37:45Z

@weaverryan #3087 addresses the necessary changes for 2.4

weaverryan and others added 30 commits May 5, 2013 19:38

[symfony#2589] Minor tweaks to DialogHelper multi-select changes

50d6886

Merge pull request symfony#2592 from WouterJ/issue_2531

05f1aaf

Documented dumpFile

[symfony#2592] Minor tweaks for Filesystem::dumpFile

80c3fb3

Merge pull request symfony#2593 from WouterJ/issue_2569

1d50d04

Updated sidebar to use Debug component

Merge pull request symfony#2599 from WouterJ/document_equal_validators

8a026ea

Documented the Comparison validators

[symfony#2565] Fixing a bad merge conflict

98c0ff6

Merge branch '2.2'

e7d1a58

Conflicts: components/console/helpers/progresshelper.rst reference/configuration/framework.rst

Fixing duplicate target "enabled"

83046d3

[symfony#2599] Minor tweaks to a bunch of new constraints documented by

4542e06

@wouterj

Merge pull request symfony#2602 from pvolok/crawler_html

c9b65d0

[2.3] Document Crawler::html method

Merge branch '2.2'

e76f69f

Conflicts: components/filesystem.rst

[symfony#2602] Adding 2.3 note about new Crawler::html method

9dc1b5f

Adding lazy services documentation as of symfony/symfony#7890

50905ff

[Components][Console] Fixed typos for table helper

c3c3e98

Merge branch '2.2'

f546b9e

Applying changes suggested by @wouterj, adding lazy_services to compo…

931091d

…nents map

Added new tag

2d9316f

Merge pull request symfony#2624 from pierredup/master

abe537f

[Components][Console] Fixed typos for table helper

Made the Icu component compatible with ICU 3.8

438c824

Merge pull request symfony#2640 from bschussek/icu-3.8

a981ae7

Made the Icu component compatible with ICU 3.8

Merge pull request symfony#2619 from Ocramius/feature/proxy-manager-b…

a2bc822

…ridge Adding lazy services documentation as of symfony/symfony#7890

[symfony#2619] Tweaks for new proxy/lazy services entry

d7ea3a5

Merge branch '2.2'

2b7dcf9

Conflicts: components/yaml/introduction.rst

Documented ProgressHelper's clear() method.

ac3df57

Formatting fix and additional example

ca6d87a

removed double "the"

1c2ff32

Capitalization

f20b2e3

Merge branch '2.2' into 2.3

59d6e6e

Conflicts: components/yaml/introduction.rst

Merge branch '2.3'

4c06860

Conflicts: components/yaml/introduction.rst

[Book/Form] minor fix, superfluous word

86d7d76

weaverryan and others added 13 commits September 28, 2013 17:55

Merge branch '2.3'

c8dfa9e

[symfony#2913] Removing versionadded 2.1 messages from the master branch

574d7a8

Merge pull request symfony#2947 from ChristianGaertner/patch-1

81698fe

[WCM] Added docs for the changes proposed in symfony/symfony#8908

[symfony#2947] Adding versionadded details

7e0cb8b

Merge pull request symfony#2960 from WouterJ/doc_php_stopwatch

0f674c1

Documented Stopwatch Helper

[symfony#2960] Minor changes thanks to @xabbuh

2be6510

Merge pull request symfony#2728 from imobilis/ticket_7884

6a13396

[WCM] [Process] Doc for output flush methods.

[symfony#2728] Minor tweaks to docs on Process flush methods

88f051a

Merge pull request symfony#2971 from xabbuh/issue-2958

32c510f

document the getEncodings() method of the Request class

[symfony#2971] Minor language tweak to be consistent with the other a…

66f1672

…reas The language used by @xabbuh is actually straight from the PHPDoc, which is cool, but I don't love the wording there, and having some variety in wording might help clarification.

Merge branch '2.2' into 2.3

08056fd

Merge branch '2.3'

d4f9478

fix versionadded directive

e52ac5c

xabbuh and others added 10 commits October 5, 2013 09:18

fix build errors

a7da13a

Merge branch '2.2' into 2.3

7a3d2a4

[symfony#2728] Fixing typo thanks to @xabbuh

4732a76

Merge pull request symfony#3036 from xabbuh/fix-build-errors-master

022763a

fix versionadded directive

Merge pull request symfony#2993 from WouterJ/issue_2846

43a5cec

Fixed wrong redirection of virtuals -> inherit_data

Merge pull request symfony#3035 from xabbuh/fix-build-errors-2.3

d14bf28

fix build errors

Merge remote-tracking branch 'origin/2.3' into 2.3

f1436a5

Merge branch '2.3'

adcef55

Conflicts: reference/constraints/Image.rst

[symfony#2870] put back the command argument when executing a command…

531f2a8

… in the CommandTester

weaverryan closed this Oct 14, 2013

xabbuh deleted the issue-2870 branch October 15, 2013 04:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[#2870] put back the command argument when executing a command in the Co... #3033

[#2870] put back the command argument when executing a command in the Co... #3033

Uh oh!

xabbuh commented Oct 4, 2013

Uh oh!

stof commented Oct 5, 2013

Uh oh!

xabbuh commented Oct 5, 2013

Uh oh!

weaverryan commented Oct 14, 2013

Uh oh!

xabbuh commented Oct 15, 2013

Uh oh!

xabbuh commented Oct 22, 2013

Uh oh!

Uh oh!

Uh oh!

[#2870] put back the command argument when executing a command in the Co... #3033

[#2870] put back the command argument when executing a command in the Co... #3033

Uh oh!

Conversation

xabbuh commented Oct 4, 2013

Uh oh!

stof commented Oct 5, 2013

Uh oh!

xabbuh commented Oct 5, 2013

Uh oh!

weaverryan commented Oct 14, 2013

Uh oh!

xabbuh commented Oct 15, 2013

Uh oh!

xabbuh commented Oct 22, 2013

Uh oh!

Uh oh!