fix build errors #3035
fix build errors #3035
Conversation
xabbuh
commented
Oct 4, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets |
| @@ -17,7 +17,8 @@ Installation | |||
| You can install the component in many different ways: | |||
|
|
|||
| * Use the official Git repository (https://github.com/symfony/Debug); | |||
| * :doc:`Install it via Composer </components/using_components>` (``symfony/debug`` on `Packagist`_). | |||
| * :doc:`Install it via Composer </components/using_components>` (``symfony/debug`` | |||
| on `Packagist`_). | |||
There was a problem hiding this comment.
-1 for this change, seems like the line break is the only thing changed and I prefer to keep it on one line, for consistency.
There was a problem hiding this comment.
No, there's another change in line 35 (fixing the link to the ClassLoader compont docs.
There was a problem hiding this comment.
yes, but please revert this line break
There was a problem hiding this comment.
Really? I thought it would be good to be in line with our 76 character per line rule.
There was a problem hiding this comment.
consistency, or do it everywhere or do it never. And in this case, I think it looks nicer to have it on one line. As with all doc standards, they are a bit lazy and not very strict :)
There was a problem hiding this comment.
If we it here, it's everywhere in this file. Thus, this file would be completely consistent. :)
But I can live with keeping it at its current state.
There was a problem hiding this comment.
but it is consistent with all other installation sections :)
There was a problem hiding this comment.
Maybe I should change them all. ;)
|
Awesome fixes, and all on the 2.3 branch - easy merge :) |