[WCM][Console] add documentation for the new method added for table dividers #3269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cordoval
commented
Dec 3, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes ( symfony/symfony#9680 ) |
| Applies to | 2.5+ |
| Fixed tickets | - |
|
fyi, I changed the PR template to use our template: http://symfony.com/doc/current/contributing/documentation/overview.html#pull-request-format |
| @@ -23,6 +23,7 @@ set headers, rows and render:: | |||
| array('960-425-059-0', 'The Lord of the Rings', 'J. R. R. Tolkien'), | |||
| array('80-902734-1-6', 'And Then There Were None', 'Agatha Christie'), | |||
| )) | |||
| ->setDividersAt(array(2)) | |||
There was a problem hiding this comment.
I don't know if I like this, because they don't really no what this exactly does
|
Can you add [WCM] to the PR title? |
|
@xabbuh done :) |
|
👍 |
|
Closing as symfony/symfony#10365 implements this feature in another way. See #3627 for some documentation about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.