-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Improving "The Quick Tour" tutorial #3562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
0b442c7
[quick_tour] simplified drastically the first two sections of "The Bi…
javiereguiluz 6e5a6a2
[quick_tour] simplified the "routing" section
javiereguiluz 63f671c
[quick_tour] updated the "Controllers" section
javiereguiluz 8a1db94
[quick_tour] updated some screenshots
javiereguiluz b6c1721
[quick_tour] finished the review of "The Big Picture" chapter
javiereguiluz 7c8c38c
[quick_tour] updated "the view" chapter
javiereguiluz be8787c
[quick tour] simplified "the controller" chapter
javiereguiluz 3a2fd71
[quick_tour] simplified "the architecture" chapter
javiereguiluz f48cbf1
[quick_tour] second pass to the "big picture" chapter
javiereguiluz 905e3e6
[quick tour] second pass to "the view" chapter
javiereguiluz cce8145
[quick_tour] second pass to "the controller" chapter and
javiereguiluz 1e1deb0
[quick_tour] second pass to "the architecture" chapter
javiereguiluz f57ad39
[quick_tour] replaced "chapter" by "part" in some tutorial parts
javiereguiluz 0d4da93
[quick_tour] removed inline links
javiereguiluz deced02
Bundle names should not be placed in literals
javiereguiluz 53ba9d5
Removed a wrongly inserted comma
javiereguiluz 4a4635d
When using server:run command, it's not necessary to add the `app_dev…
javiereguiluz 89c7dd3
Capitalized some sentences that come after a colon
javiereguiluz bd1fc95
Added a new headline to better structure the documentation
javiereguiluz 7cfc1d9
Minor rewording
javiereguiluz a22d663
Fixed the capitalization of a section heading
javiereguiluz 9f04dae
Replaced "variable" by "placeholder" when using {_format} inside a route
javiereguiluz f810f4a
Removed the animated GIF showing how to install Symfony
javiereguiluz cef3103
Added a more useful message for users that don't have PHP 5.4
javiereguiluz 1ed3dc9
Grammar fixes proposed by @weaverryan and @WouterJ
javiereguiluz c7d3fac
Restored the original line that explained how a routing file is imported
javiereguiluz fa1d018
Restored all the original introductions for each tutorial part
javiereguiluz 304d4ce
[quick_tour] rewording and grammar fixes suggested by @weaverryan
javiereguiluz 3b430f8
[quick_tour] more rewording and grammar fixes
javiereguiluz c911698
[quick_tour] removed an unneeded comma
javiereguiluz ef88ae2
[quick_tour] rewording and grammar fixes noted by @xabbuh
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we shouldn't say that a bundles overrides another bundle but instead extends a parent bundle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we have explicitely changed this from parent to override (one of my first doc contributions) as there is no parent/child relation, the getParent method is confusing and only there as it means a big BC change.
More information in symfony/symfony#4347 and the related doc PR and fabian's commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the clarification.