[Contributing][Code] add note on Symfony SE forks for bug reports #4072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| * *(optional)* It helps others a lot to fix the bug you discovered if you | ||
| fork the `Symfony Standard Edition`_ and reproduce your issue on a new | ||
| branch. |
There was a problem hiding this comment.
Be careful here. Forking the Symfony SE is not the right for all bug reports. When reporting a bug on some standalone component, providing a failing test case if much better. Forking should be used only for problems spanning multiple layers.
There was a problem hiding this comment.
You're right. Maybe we should better intodruce a subsection explaining both ways to make a bug reproducable.
|
I reworded the item a bit and moved it just below the one that advises to provide a unit test. I think it's more clear this way. |
|
Nice small edition 👍 and thanks! |
weaverryan
added a commit
that referenced
this pull request
Aug 13, 2014
… reports (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Contributing][Code] add note on Symfony SE forks for bug reports | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | As @javiereguiluz stated in symfony/symfony#11494, the way to report bugs can be improved. One of the things that could be done, is to add a note to make a bug reproducable by forking the Symfony Standard Edition with the modifications needed to reproduce a particular issue. Commits ------- ebf1415 add note on Symfony SE forks for bug reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @javiereguiluz stated in symfony/symfony#11494, the way to report bugs can be improved. One of the things that could be done, is to add a note to make a bug reproducable by forking the Symfony Standard Edition with the modifications needed to reproduce a particular issue.