Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GetResponse*Events stop after a response was set #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2014
Merged

GetResponse*Events stop after a response was set #4532

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25e1069
Added notes specifying the propagation behaviour for kernel.view and …
Lumbendil Nov 29, 2014
d13943a
Add missing info about kernel.request event.
Lumbendil Nov 29, 2014
e729750
Changed phrasing to explain the effects off propagation stopping.
Lumbendil Nov 29, 2014
bebce0e
Fix incorrect event name.
Lumbendil Nov 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed phrasing to explain the effects off propagation stopping.
  • Loading branch information
@Lumbendil
Lumbendil committed Nov 29, 2014
commit e72975037c1ce553150baff88e5a546c312bb203
6 changes: 3 additions & 3 deletions components/http_kernel/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ attributes).
.. note::

When setting a response for the ``kernel.view`` event, the propagation
is stopped, so the lower priority listeners on that event don't get called.
is stopped. This means listeners with lower priority won't be executed.

.. sidebar:: ``kernel.request`` in the Symfony Framework

Expand Down Expand Up @@ -399,7 +399,7 @@ return a ``Response``.
.. note::

When setting a response for the ``kernel.view`` event, the propagation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 times the same note?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for different events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/symfony/symfony-docs/pull/4532/files#diff-e15ca2d264f8727e6c744c50d918aecaR172
https://github.com/symfony/symfony-docs/pull/4532/files#diff-e15ca2d264f8727e6c744c50d918aecaR401

2 times " When setting a response for the kernel.view event, the propagation"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes you're right. Should be kernel.request above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's fixed now 😄

is stopped, so the lower priority listeners on that event don't get called.
is stopped. This means listeners with lower priority won't be executed.

.. sidebar:: ``kernel.view`` in the Symfony Framework

Expand Down Expand Up @@ -535,7 +535,7 @@ below for more details).
.. note::

When setting a response for the ``kernel.exception`` event, the propagation
is stopped, so the lower priority listeners on that event don't get called.
is stopped. This means listeners with lower priority won't be executed.

.. sidebar:: ``kernel.exception`` in the Symfony Framework

Expand Down