Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Added usage exemple for the URL validator #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

saro0h
Copy link
Contributor

@saro0h saro0h commented Dec 11, 2014

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets ~

@timglabisch
Copy link
Contributor

don't get me wrong, i really like the change but other constraints doesn't follow this example.
most constraints doesn't add examples for default values.

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

I agree with @timglabisch. In my opinion, the basic examples would be harder to understand if we included the default values for each constraint option.

@saro0h
Copy link
Contributor Author

saro0h commented Dec 12, 2014

I disagree: when I began with this topic, I was sad to actually not have any example. Moreover, this ~ is not very helping for those who are looking for exemple(s).

@wouterj
Copy link
Member

wouterj commented Dec 13, 2014

All default values are already documented in the options list. This is a reference documentation, not a beginners guide. If you take a look at book/validation, you'll see enough examples on how to configure constraints and what ~ means.

@saro0h
Copy link
Contributor Author

saro0h commented Dec 16, 2014

Should I close this PR then ?

@xabbuh
Copy link
Member

xabbuh commented Mar 8, 2015

Yes, I think that's the best option here. Anyway, thank you for contributing to the docs, @saro0h. Hope to see you back soon with other improvements.

@xabbuh xabbuh closed this Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants