Add code sample and some more details to the CS page #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->foo = $this->init($dummy); | ||
| } | ||
|
|
||
| private function init($dummy) |
There was a problem hiding this comment.
you should add some phpdoc. documentign the code is better too :)
|
Updated according to feedback. Good to merge now I think @weaverryan. |
weaverryan
added a commit
that referenced
this pull request
Jul 6, 2011
Add code sample and some more details to the CS page
|
Really very nice @Seldaek - I don't know how we hadn't thought to put an actual code example in there before... |
|
Yeah, when you know what's in it, it seems fine, but when I saw the reaction of someone after giving him the link, it was clear it needed more expressiveness ;) We need to user-test the docs more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.