Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PSR-7] Bridge documentation#5331

Merged
weaverryan merged 1 commit into
symfony:2.7from
dunglas:psr7_bridge
Jun 19, 2015
Merged

[PSR-7] Bridge documentation#5331
weaverryan merged 1 commit into
symfony:2.7from
dunglas:psr7_bridge

Conversation

@dunglas
Copy link
Copy Markdown
Member

@dunglas dunglas commented May 29, 2015

Q A
Doc fix? no
New docs? yes
Applies to 2.7 symfony/psr-http-message-bridge#1
Fixed tickets n/a

Documents the PSR-7 Bridge. As there was no previous doc for bridges, I created a structure but not sur if this is a good idea.

@wouterj
Copy link
Copy Markdown
Member

wouterj commented May 29, 2015

I think it's better to just have a new cookbook section about PSR-7 and how to use it in your application (instead of creating a new section)

fabpot added a commit to symfony/psr-http-message-bridge that referenced this pull request May 29, 2015
This PR was squashed before being merged into the 2.8-dev branch (closes #1).

Discussion
----------

Initial support

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs#5331

- [x] Composer dependencies
- [x] Interfaces
- [x] Stub
- [x] HttpFoundationFactory implementation
- [x] DiactorosFactory implementation
- [x] StreamedResponse

Commits
-------

ca41146 Initial support
Comment thread bridges/psr7.rst Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$psrResponse =

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Jun 9, 2015

Moved to a cookbook entry.

Comment thread cookbook/psr7.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backslashes need to be escaped for the ResponseInterface too.

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Jun 15, 2015

@xabbuh done

Comment thread cookbook/map.rst.inc Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last * needs to be removed.

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Jun 15, 2015

We also need an entry for the new document in the toctree in /cookbook/index.rst.

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Jun 17, 2015

Should be ok now.

@harikt
Copy link
Copy Markdown
Contributor

harikt commented Jun 18, 2015

I have a question : Does Symfony 3.0 http foundation will make use of psr-7 or it will be using the bridge itself ?

I have noticed some issues regarding splitting of the session component from http foundation etc.

Thank you.

@weaverryan
Copy link
Copy Markdown
Contributor

@harikt 3.0 will not use psr-7 (so you'd use the bridge like now). We need to protect backwards compatibility - but we are discussing the best (and most responsible way) to move towards psr-7.

@weaverryan weaverryan merged commit 695fe21 into symfony:2.7 Jun 19, 2015
weaverryan added a commit that referenced this pull request Jun 19, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[PSR-7] Bridge documentation

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.7 symfony/psr-http-message-bridge#1
| Fixed tickets | n/a

Documents the PSR-7 Bridge. As there was no previous doc for bridges, I created a structure but not sur if this is a good idea.

Commits
-------

695fe21 [PSR-7] Bridge documentation
weaverryan added a commit that referenced this pull request Jun 19, 2015
@weaverryan
Copy link
Copy Markdown
Contributor

Awesome @dunglas - thanks!

weaverryan added a commit that referenced this pull request Jun 19, 2015
* 2.7: (23 commits)
  [#5331] Tiny typo
  [#5373] Small tweak per Stof's comment
  [PSR-7] Bridge documentation
  Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7
  Fixed a minor grammar issue
  Fixed typos
  Link to the official repository of the bundle.
  Added mentions to some popular (and useful) Symfony bundles
  [#5095] Fixing a typo and updating to a more realistic example
  [Components][ClassLoader] remove DebugClassLoader
  [#4228] Move synthetic services to its own recipe
  clarify bundle installation instructions
  Implemented the suggestions made by Christian and Wouter
  Replace phpDocumentor by the standard PHPDoc
  Implemented the changes suggested by reviewers
  Fixed an internal link reference
  Reviewed the Bundles cookbook articles
  Updated the list of reserved domains and the URL reference
  Use the reserved domains example.com and example.org
  Constraints - empty strings and null values
  ...
weaverryan added a commit that referenced this pull request Jun 19, 2015
* 2.8: (24 commits)
  [#5331] Tiny typo
  [#5373] Small tweak per Stof's comment
  Added depreciation note for the cascade_validation constraint and updated position of depreciation notes
  [PSR-7] Bridge documentation
  Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7
  Fixed a minor grammar issue
  Fixed typos
  Link to the official repository of the bundle.
  Added mentions to some popular (and useful) Symfony bundles
  [#5095] Fixing a typo and updating to a more realistic example
  [Components][ClassLoader] remove DebugClassLoader
  [#4228] Move synthetic services to its own recipe
  clarify bundle installation instructions
  Implemented the suggestions made by Christian and Wouter
  Replace phpDocumentor by the standard PHPDoc
  Implemented the changes suggested by reviewers
  Fixed an internal link reference
  Reviewed the Bundles cookbook articles
  Updated the list of reserved domains and the URL reference
  Use the reserved domains example.com and example.org
  ...
xabbuh pushed a commit to xabbuh/symfony-docs that referenced this pull request Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants