[Cookbook][Templating] Add note about cache warming of namespaced twig template paths prior to 2.8 #5391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbond
commented
Jun 12, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | symfony/symfony#14764 |
| Applies to | 2.8+ |
| Fixed tickets | n/a |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 30, 2015
…hs (kbond) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #14764). Discussion ---------- [TwigBundle] Warmup twig templates in non-standard paths | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12507 | License | MIT | Doc PR | symfony/symfony-docs#5391 Commits ------- 96cce38 Warmup twig templates in non-standard paths (closes #12507)
|
The upstream PR is now merged. I would actually like to do this PR just the other way: Add a caution saying that these templates aren't warmed up in 2.3 and remove the caution in the 2.8 branch. |
|
Ok, I can open a new PR. |
|
cool! :) |
xabbuh
added a commit
that referenced
this pull request
Oct 3, 2015
…paced twig templates (kbond) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Templating] Add note about cache warming namespaced twig templates | Q | A | ------------- | --- | Doc fix? | yes | New docs? | symfony/symfony#14764 | Applies to | 2.3 | Fixed tickets | #5391 Commits ------- cbd86ce add note about cache warming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.