Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecated class replacement #5665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

stampycode
Copy link

Assert\True class is deprecated since version 2.7 and will be removed in 3.0. Use the IsTrue class in the same namespace instead.

Assert\True class is deprecated since version 2.7 and will be removed in 3.0. Use the IsTrue class in the same namespace instead.
@stof
Copy link
Member

stof commented Sep 1, 2015

this should be applied in 2.3+ (the IsTrue class was introduced in 2.3.29+ as the support of PHP 7 was considered to be a bugfix)

@javiereguiluz
Copy link
Member

@stampycode although this pull request must be applied to another branch, you probably don't need to make any change. Our doc managers can switch the branch when merging, so let's wait to see what do they think about this.

@stof
Copy link
Member

stof commented Sep 1, 2015

well, for me, it is a 👍. We should avoid using deprecated APIs in the doc

@xabbuh
Copy link
Member

xabbuh commented Sep 5, 2015

Looks good @stampycode. Could you also make the changes for the IsFalse and IsNull constraints and also do it in the reference section (you can have a look at symfony/symfony#14228 for more details)?

@stampycode
Copy link
Author

Sure, want me to make the PR into branch 2.7, or somewhere else?

@stampycode
Copy link
Author

#5677

@stof
Copy link
Member

stof commented Sep 8, 2015

These changes should be done in the 2.3 branch IMO, as the classes are available in 2.3.29+ (for PHP 7 support)

@weaverryan
Copy link
Member

Closing as this was re-opened with more changes in #5677

@weaverryan weaverryan closed this Oct 15, 2015
weaverryan added a commit that referenced this pull request Oct 15, 2015
…ors in docs (Tim Stamp)

This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5677).

Discussion
----------

replacing deprecated usage of True, False, Null validators in docs

related: #5665

Commits
-------

9a5ea56 Updating book examples to not use deprecated validation methods
627d74d Updated constraint reference docs for Null->IsNull, False->IsFalse, True->IsTrue
a90ea7c Creating placeholder constraint rst docs for deprecated usage
639be4b Renaming constraint rst files to Is* to preserve edit history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants