Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify code example in "Adding custom extensions" section #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Simplify code example in "Adding custom extensions" section #5962

wants to merge 5 commits into from

Conversation

snoek09
Copy link

@snoek09 snoek09 commented Dec 5, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #5225

As suggested by @webmozart and @stof.

@snoek09 snoek09 changed the title simplify code example as suggested by @webmozart and @stof Simplify code example in "Adding custom extensions" section Dec 5, 2015
@snoek09 snoek09 closed this Dec 5, 2015
@snoek09 snoek09 reopened this Dec 5, 2015
@snoek09 snoek09 closed this Dec 5, 2015
@snoek09 snoek09 reopened this Dec 5, 2015
@xabbuh
Copy link
Member

xabbuh commented Dec 9, 2015

👍 Great work!

wouterj added a commit that referenced this pull request Dec 17, 2015
…tion (snoek09)

This PR was squashed before being merged into the 2.3 branch (closes #5962).

Discussion
----------

Simplify code example in "Adding custom extensions" section

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5225

 As suggested by @webmozart and @stof.

Commits
-------

d203ef0 Simplify code example in "Adding custom extensions" section
wouterj added a commit that referenced this pull request Dec 17, 2015
@wouterj
Copy link
Member

wouterj commented Dec 17, 2015

Great work, thanks again @snoek09! I've merged these into the documentation now.

I've updated the related paragraph in d47e616, as it was still talking about registering the other extensions using the factory.

@wouterj wouterj closed this Dec 17, 2015
@snoek09 snoek09 deleted the simplify-adding-custom-extensions-code branch April 13, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants