DumpFile() third argument is deprecated and doesn't exists anymore in… #6906

mickaelandrieu · 2016-08-22T14:27:24Z

DumpFile() third argument is deprecated and doesn't exists anymore since 3.0.*

* 2.7: Fixing bad conflict fix

* 2.8: Fixing bad conflict fix

* 2.7: fix status code in snippet

* 2.8: fix status code in snippet

Ldap is the new user provider in Symfony 2.8, so it would be good to mention it in the list of all user providers.

This PR was merged into the 2.8 branch. Discussion ---------- fix broken merge Commits ------- 5ba5224 fix broken merge

…ta` option

…Type (kgilden, HeahDude)

The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.

This PR was submitted for the 3.0 branch but it was merged into the 2.8 branch instead (closes symfony#6509). Discussion ---------- Update http_kernel_httpkernel_class.rst The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers. Commits ------- ee94747 Update http_kernel_httpkernel_class.rst

@pborreli

This PR was merged into the 2.8 branch. Discussion ---------- fix typo | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >= 2.8 I feel in @pborreli's shoes Commits ------- 1bfe021 fix typo

…hov) This PR was merged into the 2.8 branch. Discussion ---------- Added ldap to the list of user providers | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8+ | Fixed tickets | n/a Ldap is the new user provider in Symfony 2.8, so it would be good to mention it in the list of all user providers. Commits ------- f723ea5 Added ldap to the list of user providers

* 2.7: remove documentation of not supported "verbose" option value use port 587 in Amazon SES example [symfony#6464] Minor tweak Fix one more occurence of /read Fix typo Added possible values for access_decision_manager.strategy

* 2.8: [symfony#6465] fix newline position remove documentation of not supported "verbose" option value Update http_kernel_httpkernel_class.rst use port 587 in Amazon SES example fix typo [symfony#6464] Minor tweak Fix one more occurence of /read Fix typo Added ldap to the list of user providers Added possible values for access_decision_manager.strategy

* 2.7: [symfony#6472] Updating description, after change Avoid confusion Added file paths Fixes and rewords Documented the config options of TwigBundle [symfony#6427] Adding a header Tests: Explain how to add or remove data in a collection of forms Document constraint validator alias optional

* 2.8: [symfony#6472] Updating description, after change Avoid confusion Added file paths Fixes and rewords Documented the config options of TwigBundle [symfony#6427] Adding a header Tests: Explain how to add or remove data in a collection of forms Document constraint validator alias optional

* 2.7: On line 360 the header not working The `$link` argument must be passed as a reference Fix snippet

* 2.8: On line 360 the header not working The `$link` argument must be passed as a reference Fix snippet

The CssSelector class does not exists since 2.8. The behavior is now automatic if the content is an XML file.

- fix typo from services to service in the first paragraph - fix typo from "if your buildForm" to "of your buildForm"

@dunglas

…erbaldwin) This PR was merged into the 2.8 branch. Discussion ---------- [PropertyInfo] Add Component Documentation | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#15858) | Applies to | `2.8`, `3.0` | Fixed tickets | N/A This is still a *work in progress*, but I'd like feedback from anyone regarding structure, grammar and any other improvements while I continue. After speaking with @dunglas, I'm creating a new PR due our branches differing by about 400 commits. Commits ------- a0409d7 Update Reference to Service Container Tags 78ea4a5 Update PropertyAccess Component Path 7b786af Fix Incorrect Indent 96b139b Suggested Changes cf7a0ea Add PropertyInfo Component Documentation

* 2.7: Adding details about the Symfony framework as comments Adjust Application use statement replacing with index, otherwise these documents are not included in *any* index Removed the "Learn more" section Created a "Platform as a Service" section Minor improvements Fixed the "make" command Fixed again the tricky list syntax Fixed the syntax of the list Minor fixes Reword the third step Added the missing link references Updated the instructions to build docs locally Refactore how to get the container in a test Fixed a reference Created the main article about "deployment"

* 2.8: (31 commits) Adding details about the Symfony framework as comments Adjust Application use statement replacing with index, otherwise these documents are not included in *any* index Error in CSRF example code snippet Added missing reference Update serializer.rst Adding missing link reference for symfony#6877, because someone must have been in a hurry :) Remove additional backslash Add a class specificity for SplFileInfo Update Reference to Service Container Tags Remove extra quotes from ExprBuilder::thenInvalid() usage Update PropertyAccess Component Path Fix Incorrect Indent Suggested Changes Add PropertyInfo Component Documentation missing "`" added lyrixx to the core team Remove redundant verb Removed the "Learn more" section Created a "Platform as a Service" section ...

* origin/3.0:

This PR was merged into the 3.0 branch. Discussion ---------- [FormComponent] Fix typos - fix typo from services to service in the first paragraph - fix typo from "if your buildForm" to "of your buildForm" Commits ------- 6d282e4 Fix typos

"in_memory" does not exist. This is a just a provider name. The real keyword is "memory"

This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes symfony#6892). Discussion ---------- Update custom_provider.rst "in_memory" does not exist. This is a just a provider name. The real keyword is "memory" Commits ------- 2d5b420 Update custom_provider.rst

* 2.7: [symfony#6892] The provider is called `memory` Fix typos Update templating.rst Update templating.rst Adds bin folder creation instruction service_container : fix php Definition instance [Routing] Fix a route path in a routing example Minor unrelated spacing fixes Update doctrine.rst

* 2.8: Update custom_provider.rst [symfony#6892] The provider is called `memory` Fix typos Update templating.rst Update templating.rst Adds bin folder creation instruction service_container : fix php Definition instance [Routing] Fix a route path in a routing example Minor unrelated spacing fixes Update doctrine.rst

… Sf3

wouterj · 2016-08-23T09:10:04Z

👍
status: reviewed

I think we should merge this in 2.7, as it's deprecated in 2.3. Documenting deprecated features doesn't make a lot of sense here imo.

(btw, 3.0 has reached eom, so this should not be merged in 3.0).

mickaelandrieu · 2016-08-23T09:31:58Z

Hi @wouterj,
if docs remains published and online (regarding the 3.0), we should fix it, right ?
My only interest here is to not publish mistakes, regardless the maintenance status of versions :D

Mickaël

wouterj · 2016-08-23T09:35:09Z

My only interest here is to not publish mistakes, regardless the maintenance status of versions :D

That's not something we do in the docs. Eom versions will have eom docs. Otherwise, we end up maintaining all branch versions (even 2.0).

Please note that eom version docs will have a big yellow warning at the top: http://symfony.com/doc/2.3/components/filesystem And the eom versions don't exists in the version checker.

mickaelandrieu · 2016-08-23T09:44:34Z

Please note that eom version docs will have a big yellow warning at the top: http://symfony.com/doc/2.3/components/filesystem And the eom versions don't exists in the version checker.

Ok, I believed every "published" versions of docs were maintained (and so on, the others one were discontinued).

Following what you say, the 3.0 should have the "yellow banner" very soon ? Do you want me to edit the branch of this contribution (from 3.0 to 3.1 ?).

Mickaël

wouterj · 2016-08-23T09:47:13Z

Following what you say, the 3.0 should have the "yellow banner" very soon ? Do you want me to edit the branch of this contribution (from 3.0 to 3.1 ?).

Yes, I'll push @javiereguiluz to add it when he's back from his holiday ;)

If possible, please rebase and change this PR on 2.7.

mickaelandrieu · 2016-08-23T09:51:04Z

arf, wanted to try the new "change base" button ^^

=> PR closed in favor of #6909

wouterj · 2016-08-23T09:52:00Z

@mickaelandrieu why didn't the edit button work? (just interested, so I know when I can ask new contributors to edit the base branch)

mickaelandrieu · 2016-08-23T09:58:03Z

@wouterj hmm I'd say because there is a big difference between 2.7 and 3.0... it's not a rebase button, it's only made a push on a new base, regarless the origin branch of the contribution (I've started on 3.0 so, all commits from 3.0 were added).

The button is fine for another mistake: If I have started my contribution in 2.7 branch and pushed it on 3.0, I can re edit my contribution to select the "good" branch.

wouterj · 2016-08-23T10:04:13Z

@mickaelandrieu I think this would be fixed if you rebase your branch locally (git rebase --onto origin/2.7 origin/3.0) and then force push.

…s anymore (mickaelandrieu) This PR was merged into the 2.7 branch. Discussion ---------- DumpFile() third argument is deprecated and doesn't exists anymore see #6906 nl;dr; ``dumpFile()`` third argument is deprecated and removed in 3.x, we shouldn't document it. Commits ------- 155e48b DumpFile() third argument is deprecated and doesn't exists anymore in 3.x

weaverryan and others added 30 commits April 11, 2016 21:14

Merge branch '2.7' into 2.8

cba307c

* 2.7: Fixing bad conflict fix

Merge branch '2.8' into 3.0

b7c70e6

* 2.8: Fixing bad conflict fix

Merge branch '2.7' into 2.8

164db85

* 2.7: fix status code in snippet

Merge branch '2.8' into 3.0

ffb40b9

* 2.8: fix status code in snippet

Added ldap to the list of user providers

f723ea5

Ldap is the new user provider in Symfony 2.8, so it would be good to mention it in the list of all user providers.

fix broken merge

5ba5224

minor symfony#6471 fix broken merge (xabbuh)

5726c9b

This PR was merged into the 2.8 branch. Discussion ---------- fix broken merge Commits ------- 5ba5224 fix broken merge

Merge branch '2.8' into 3.0

a9c9865

Merge branch '2.7' into 2.8

282602e

[Form] Document CollectionType's prototype_data

a77a4b5

[Form] defined default and added example CollectionType `prototype_da…

472fcd6

…ta` option

feature symfony#6450 [Form] added prototype_data option in Collection…

323ebcc

…Type (kgilden, HeahDude)

Merge branch '2.8' into 3.0

43804ba

[symfony#6450] Remove versionadded in 3.0

3b1f19e

[symfony#6450] Use a reference for the field option

5439c7a

Merge branch '2.8' into 3.0

61b4cdd

fix typo

1bfe021

Update http_kernel_httpkernel_class.rst

ee94747

The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.

minor symfony#6507 fix typo (tyx)

1c3a7bd

This PR was merged into the 2.8 branch. Discussion ---------- fix typo | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >= 2.8 I feel in @pborreli's shoes Commits ------- 1bfe021 fix typo

[symfony#6465] fix newline position

1bc1406

Merge branch '2.7' into 2.8

fb7d583

* 2.7: remove documentation of not supported "verbose" option value use port 587 in Amazon SES example [symfony#6464] Minor tweak Fix one more occurence of /read Fix typo Added possible values for access_decision_manager.strategy

Merge branch '2.7' into 2.8

a50c5a2

* 2.7: On line 360 the header not working The `$link` argument must be passed as a reference Fix snippet

Merge branch '2.8' into 3.0

bfd32d7

* 2.8: On line 360 the header not working The `$link` argument must be passed as a reference Fix snippet

[DependencyInjection] Unquote services FQCN in autowiring examples

54d84e4

[DomCrawler] Removed references to CssSelector

50a8777

The CssSelector class does not exists since 2.8. The behavior is now automatic if the content is an XML file.

wouterj and others added 13 commits August 17, 2016 11:19

Merge branch '2.7' into 2.8

f7dad82

Merge branch '2.8' into 3.0

3b9db1f

Fix typos

6d282e4

- fix typo from services to service in the first paragraph - fix typo from "if your buildForm" to "of your buildForm"

Merge remote-tracking branch 'origin/3.0' into 3.0

0986e5e

* origin/3.0:

Update custom_provider.rst

2d5b420

"in_memory" does not exist. This is a just a provider name. The real keyword is "memory"

DumpFile() third argument is deprecated and doesn't exists anymore in…

28bd6b7

… Sf3

carsonbot added the Status: Needs Review label Aug 22, 2016

carsonbot added Status: Reviewed and removed Status: Needs Review labels Aug 23, 2016

mickaelandrieu changed the base branch from 3.0 to 2.7 August 23, 2016 09:48

mickaelandrieu closed this Aug 23, 2016

mickaelandrieu deleted the patch-4 branch August 23, 2016 09:48

mickaelandrieu mentioned this pull request Aug 23, 2016

DumpFile() third argument is deprecated and doesn't exists anymore #6909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DumpFile() third argument is deprecated and doesn't exists anymore in… #6906

DumpFile() third argument is deprecated and doesn't exists anymore in… #6906

mickaelandrieu commented Aug 22, 2016 •

edited

Loading

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 23, 2016 •

edited

Loading

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 23, 2016

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 23, 2016 •

edited

Loading

wouterj commented Aug 23, 2016 •

edited

Loading

mickaelandrieu commented Aug 23, 2016

wouterj commented Aug 23, 2016

DumpFile() third argument is deprecated and doesn't exists anymore in… #6906

DumpFile() third argument is deprecated and doesn't exists anymore in… #6906

Conversation

mickaelandrieu commented Aug 22, 2016 • edited Loading

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 23, 2016 • edited Loading

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 23, 2016

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 23, 2016 • edited Loading

wouterj commented Aug 23, 2016 • edited Loading

mickaelandrieu commented Aug 23, 2016

wouterj commented Aug 23, 2016

mickaelandrieu commented Aug 22, 2016 •

edited

Loading

mickaelandrieu commented Aug 23, 2016 •

edited

Loading

mickaelandrieu commented Aug 23, 2016 •

edited

Loading

wouterj commented Aug 23, 2016 •

edited

Loading