[Serializer] Support specifying format for DateTimeNormalizer::denormalize #7063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Oct 17, 2016
…malizer::denormalize (teohhanhui) This PR was merged into the 3.2-dev branch. Discussion ---------- [Serializer] Support specifying format for DateTimeNormalizer::denormalize | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#7063 Commits ------- ff23924 [Serializer] Support specifying format for DateTimeNormalizer::denormalize
wouterj
reviewed
Nov 8, 2016
| @@ -528,6 +528,10 @@ There are several types of normalizers available: | |||
| :phpclass:`DateTime` and :phpclass:`DateTimeImmutable`) into strings. | |||
| By default it uses the RFC3339_ format. | |||
|
|
|||
| .. versionadded:: 3.2 | |||
| Support for specifying datetime format during denormalization was added to | |||
| ``DateTimeNormalizer`` in Symfony 3.2 | |||
There was a problem hiding this comment.
please indent this complete directive to the same level as the description at line 527 - 529.
|
👍 I've left one minor comment, but we can also fix it during merging. In the future, we may want to document all available settings and the like. status: reviewed |
|
👍 |
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
…alizer::denormalize (teohhanhui) This PR was merged into the master branch. Discussion ---------- [Serializer] Support specifying format for DateTimeNormalizer::denormalize Waiting for symfony/symfony#20217 to be merged. Commits ------- 57bf969 [Serializer] Support specifying format for DateTimeNormalizer::denormalize
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
|
Thanks @teohhanhui! I've fixed my minor comment in 2083d9d and created an issue to document all these options in #7135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for symfony/symfony#20217 to be merged.