-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add a warning about routes parameters names limitations #7139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 14, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
OskarStark
approved these changes
Nov 14, 2016
Thank you @fancyweb. |
xabbuh
added a commit
that referenced
this pull request
Nov 22, 2016
…fancyweb, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Add a warning about routes parameters names limitations @wouterj @xabbuh I'm sorry guys I had to do a new branch and a new PR because I failed in the old one. I shouldn't have used the fast GitHub edit method. I fixed the indentation to 4 spaces. Also I thought this kind of information fitted more in the "advanced" area along with the special parameters than in the basic examples. Follow up to #7133 Commits ------- cadef60 Use "route placeholder" instead of "route parameter" 6b0f53c Add a warning about routes parameters names limitations
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Nov 25, 2016
… be used as a PCRE subpattern name (fancyweb) This PR was squashed before being merged into the 2.7 branch (closes #20474). Discussion ---------- [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#7139 This is a follow up PR to #20327. I also decided to improve the current `is_numeric()` check that is done by a truer one. The current limitation is that a PCRE subpattern name must not start with a digit which is different. Commits ------- 73fbd08 [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
symfony-splitter
pushed a commit
to symfony/routing
that referenced
this pull request
Nov 25, 2016
… be used as a PCRE subpattern name (fancyweb) This PR was squashed before being merged into the 2.7 branch (closes #20474). Discussion ---------- [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#7139 This is a follow up PR to symfony/symfony#20327. I also decided to improve the current `is_numeric()` check that is done by a truer one. The current limitation is that a PCRE subpattern name must not start with a digit which is different. Commits ------- 73fbd08 [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wouterj @xabbuh
I'm sorry guys I had to do a new branch and a new PR because I failed in the old one. I shouldn't have used the fast GitHub edit method.
I fixed the indentation to 4 spaces.
Also I thought this kind of information fitted more in the "advanced" area along with the special parameters than in the basic examples.
Follow up to #7133