Add documentation for CallbackChoiceLoader #7219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
suggested changes
Dec 3, 2016
| @@ -184,6 +184,19 @@ The ``choice_loader`` can be used to only partially load the choices in cases wh | |||
| a fully-loaded list is not necessary. This is only needed in advanced cases and | |||
| would replace the ``choices`` option. | |||
|
|
|||
| You can use an instance of :class:`Symfony\\Component\\Form\\ChoiceList\\Loader\\CallbackChoiceLoader` | |||
There was a problem hiding this comment.
Missing a versionadded note
| return StaticClass::getConstants(); | ||
| }, | ||
| )); | ||
|
|
There was a problem hiding this comment.
We could precise that, the call won't happen if there is a redirection (i.e the view is not built), AND if there is no pre set data or submitted data. Because otherwise we'll need to transform the value to a model choice (or the opposite) and that implies loading choices too.
|
Thank you again @sawmurai :) 👍 Status: Reviewed |
|
👍 |
|
Thank you @sawmurai. |
xabbuh
added a commit
that referenced
this pull request
Mar 3, 2017
…aviereguiluz) This PR was merged into the 3.2 branch. Discussion ---------- Add documentation for CallbackChoiceLoader PR for #7181 Commits ------- 5838635 Make lines shorter to comply with 80-char limit 731617f Clearify behaviour of CallbackChoiceLoader e5e9a5d Add documentation for CallbackChoiceLoader
xabbuh
added a commit
that referenced
this pull request
Mar 3, 2017
xabbuh
added a commit
that referenced
this pull request
Mar 4, 2017
* 3.2: (24 commits) Minor rewords Update session_configuration.rst [#7522] minor wording improvement [#7513] fix line length Update 'ide' example in framework.rst [#7219] move versionadded in front of description Improved the image for Doctrine + Web Debug Toolbar [Serializer] Docs for the PropertyInfo integration Finished this PR section chronology in comment Removed the example about Redis Update cache.rst Update bundles/configuration.rst Fix typos Removed tip that was meant for the 2.x versions fix usage of the session flag bag API Add caution related to deprecate mail transport Use https URLs when possible [Requirements] Clarify what are JSON and ctype Proposed a minor reword ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #7181