Improvements on flash message doc #7555
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you have any problem with the existing code? In theory, the new code would behave the same as before, because the |
|
@javiereguiluz Hi, btw I had, but i saw that we already have an existing PR to solve the problem :) Thanks |
|
@javiereguiluz With the original code + the fix in #7554 : Symfony 3.2.2 |
|
@lerox sorry, you are absolutely right!! Luckily this will be soon merged. Thanks! |
xabbuh
reviewed
Mar 1, 2017
| </div> | ||
| {% endif %} | ||
| {% endfor %} | ||
| {% if app.session.flashBag.keys %} |
There was a problem hiding this comment.
Actually, this is not part of #7554.
xabbuh
added a commit
that referenced
this pull request
Mar 1, 2017
…e (javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Fixed the way flash messages are retrieved in the template In #7432 I changed the code of the templates to get the flash messages. I don't know why I did that ... because it's completely wrong 😵 In #7555 @lerox pointed this issue and I can confirm it:  So, let's revert it. Commits ------- 8ac43ca Fixed the way flash messages are retrieved in the template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.