Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update event_dispatcher.rst #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2017
Merged

Update event_dispatcher.rst #7581

merged 2 commits into from
Mar 7, 2017

Conversation

atailouloute
Copy link
Contributor

I think it's better to say the event class instance instead of the event class, because when dispatching an event we send an instance of the event class

HeahDude
HeahDude approved these changes Mar 6, 2017
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

javiereguiluz
javiereguiluz approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I agree ... but I propose a different solution because "a class instance" is an object, so we can simplify this. Thanks!

@atailouloute
Copy link
Contributor Author

@javiereguiluz, yes object is better, should I merge the 2 commits on my branch ?

@javiereguiluz
Copy link
Member

There's no need to merge/squash/etc. because we the doc maintainers use a tool that does all that automatically!

@atailouloute
Copy link
Contributor Author

Great! Thank you

@wouterj
Copy link
Member

wouterj commented Mar 7, 2017

Thank you Ahmed.

@wouterj wouterj merged commit 6613f04 into symfony:2.7 Mar 7, 2017
wouterj added a commit that referenced this pull request Mar 7, 2017
@wouterj
minor #7581 Update event_dispatcher.rst (atailouloute, javiereguiluz)
cc47943 
This PR was merged into the 2.7 branch.

Discussion
----------

Update event_dispatcher.rst

I think it's better to say `the event class instance` instead of `the event class`, because when dispatching an event we send an instance of the event class

Commits
-------

6613f04 "class instance" -> "object"
ca51b87 Update event_dispatcher.rst
@atailouloute atailouloute deleted the patch-6 branch March 7, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atailouloute @javiereguiluz @wouterj @HeahDude @carsonbot