Fix some odd English in the PDOSessionHandler docs #7607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
HeahDude
approved these changes
Mar 9, 2017
javiereguiluz
approved these changes
Mar 10, 2017
|
Thank you @zsturgess. |
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
…gess) This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7607). Discussion ---------- Fix some odd English in the PDOSessionHandler docs Spotted this whilst looking at the PDOSessionHandler docs today, thought I would throw a patch your way. Not sure if the existing wording is meant to imply that this throws an actual PHP Notice, if so "trigger a PHP Notice" might be better, but went for the basic fix here. I think I'm meant to submit this against the oldest maintained branch, but following the guidelines for a "simple patch" (https://symfony.com/doc/current/contributing/documentation/overview.html#fast-online-contributions) brought me here. Let me know how I can go about re-targeting this and fixing the conflicts if I need to. Commits ------- 824a046 Fix some odd English in the PDOSessionHandler docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted this whilst looking at the PDOSessionHandler docs today, thought I would throw a patch your way.
Not sure if the existing wording is meant to imply that this throws an actual PHP Notice, if so "trigger a PHP Notice" might be better, but went for the basic fix here.
I think I'm meant to submit this against the oldest maintained branch, but following the guidelines for a "simple patch" (https://symfony.com/doc/current/contributing/documentation/overview.html#fast-online-contributions) brought me here. Let me know how I can go about re-targeting this and fixing the conflicts if I need to.