[Form] Make difference between data and empty_data options more visisble #7802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Apr 15, 2017
| value will be set. Use the ``data`` or ``placeholder`` options to show this | ||
| initial value in the rendered form. | ||
|
|
||
| If a form is compound, you can set ``empty_data`` as an array with field names |
There was a problem hiding this comment.
when data_class is null, otherwise it has to match the class set for this option.
xabbuh
reviewed
Apr 19, 2017
| this default value. | ||
| The ``data`` option *always* overrides the value taken from the domain data | ||
| (object) when rendering. This means the object value is also overriden when | ||
| the form edits an already persisted object, causing it to loose it's |
There was a problem hiding this comment.
[...] to lose its persisted [...]
xabbuh
reviewed
Apr 19, 2017
|
|
||
| :doc:`Form data transformers </form/data_transformers>` will still be | ||
| applied to the ``empty_data`` value. This means that an empty string will | ||
| be casted to ``null``. Use a custom data transformer if you explicitly want |
javiereguiluz
approved these changes
May 3, 2017
|
Thank you @wouterj. |
xabbuh
added a commit
that referenced
this pull request
May 4, 2017
…s more visisble (HeahDude, wouterj, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Make difference between data and empty_data options more visisble Finishes #6265 Fixes #7299, #7596 Commits ------- 64e3984 Fixed a minor typo df9b878 Fixed a minor typo f375489 Better explain empty_data values d552ea3 Readd mixed type for empty_data, it can be string, array or object 188f0ab Tried to write the important points more explicitly 5f3813d Updated the example add added a caution 4fd2d96 Addressed @stof's comment 242941a improved accuracy 67c93b6 fix typo 87b3542 explicit differences between 'data' & 'empty_data' in FormType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #6265
Fixes #7299, #7596