-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update js-datepicker usage for new jQuery UI #8091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @AdrianBorodziuk! Actually, the code is not meant for jQuery UI, but for Bootstrap's date picker. See #8047. But, obviously, it's confusing. Would you be willing to make the changes I mention in #8047 in this PR? Cheers! |
javiereguiluz
approved these changes
Dec 23, 2017
javiereguiluz
added a commit
that referenced
this pull request
Jan 5, 2018
…ziuk, javiereguiluz) This PR was merged into the 3.3 branch. Discussion ---------- Update js-datepicker usage for new jQuery UI Old variable used - "format" - doesn't work anymore in jQuery UI. Commits ------- 97f3f84 Mention that we are using Bootstrap Datepicker 4d66b50 Update js-datepicker usage for new jQuery UI
xabbuh
pushed a commit
that referenced
this pull request
Jan 5, 2018
…ziuk, javiereguiluz) This PR was merged into the 3.3 branch. Discussion ---------- Update js-datepicker usage for new jQuery UI Old variable used - "format" - doesn't work anymore in jQuery UI. Commits ------- 97f3f84 Mention that we are using Bootstrap Datepicker 4d66b50 Update js-datepicker usage for new jQuery UI
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 7, 2018
* 2.7: Mention that PSR-1 doesn't recommend CamelCase or anything else minor symfony#8091 Update js-datepicker usage for new jQuery UI (AdrianBorodziuk, javiereguiluz) minor symfony#8983 cross-reference console command testing from testing guide (dbu)
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 7, 2018
* 2.8: Mention that PSR-1 doesn't recommend CamelCase or anything else minor symfony#8091 Update js-datepicker usage for new jQuery UI (AdrianBorodziuk, javiereguiluz) minor symfony#8983 cross-reference console command testing from testing guide (dbu)
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 7, 2018
* 3.3: Update collection.rst Mention that PSR-1 doesn't recommend CamelCase or anything else minor symfony#8091 Update js-datepicker usage for new jQuery UI (AdrianBorodziuk, javiereguiluz) minor symfony#8983 cross-reference console command testing from testing guide (dbu)
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 7, 2018
* 3.4: Update collection.rst Mention that PSR-1 doesn't recommend CamelCase or anything else Fixed the XML and PHP config instead of the YAML config minor symfony#8091 Update js-datepicker usage for new jQuery UI (AdrianBorodziuk, javiereguiluz) minor symfony#8983 cross-reference console command testing from testing guide (dbu) Fix YAML config bug
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 7, 2018
* 4.0: Update collection.rst Mention that PSR-1 doesn't recommend CamelCase or anything else Fixed the XML and PHP config instead of the YAML config Use controller method injection instead of the constructor Add missing references Updated documentation to reflect best practice of using Dependency Injection over Container. Includes changes from PR symfony#8985 Removed "Accessing the Container Directly" minor symfony#8091 Update js-datepicker usage for new jQuery UI (AdrianBorodziuk, javiereguiluz) minor symfony#8983 cross-reference console command testing from testing guide (dbu) Fix YAML config bug Removed invalid examples commands are automatically registered in symfony full stack update forms.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old variable used - "format" - doesn't work anymore in jQuery UI.