Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Document the new DateIntervalNormalizer normalizer #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Serializer] Document the new DateIntervalNormalizer normalizer #8267

wants to merge 2 commits into from

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Aug 9, 2017

Waiting for symfony/symfony#23747 to be merged.

ogizanagi added a commit to symfony/symfony that referenced this pull request Sep 15, 2017
…lizer (Lctrs)

This PR was squashed before being merged into the 3.4 branch (closes #23747).

Discussion
----------

[Serializer][FrameworkBundle] Add a DateInterval normalizer

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#8267

Could be useful for API needing to submit a duration.

Most code have been adapted from @MisatoTremor's DateInterval form type. Credits to him.

Commits
-------

6185cb1 [Serializer][FrameworkBundle] Add a DateInterval normalizer
symfony-splitter pushed a commit to symfony/serializer that referenced this pull request Sep 15, 2017
…lizer (Lctrs)

This PR was squashed before being merged into the 3.4 branch (closes #23747).

Discussion
----------

[Serializer][FrameworkBundle] Add a DateInterval normalizer

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#8267

Could be useful for API needing to submit a duration.

Most code have been adapted from @MisatoTremor's DateInterval form type. Credits to him.

Commits
-------

6185cb1991 [Serializer][FrameworkBundle] Add a DateInterval normalizer
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Sep 15, 2017
…lizer (Lctrs)

This PR was squashed before being merged into the 3.4 branch (closes #23747).

Discussion
----------

[Serializer][FrameworkBundle] Add a DateInterval normalizer

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#8267

Could be useful for API needing to submit a duration.

Most code have been adapted from @MisatoTremor's DateInterval form type. Credits to him.

Commits
-------

6185cb1991 [Serializer][FrameworkBundle] Add a DateInterval normalizer
@Lctrs
Copy link
Contributor Author

Lctrs commented Sep 15, 2017

@xabbuh It has been merged. Is there any changes that need to be made to this PR ?

@xabbuh xabbuh removed the On hold label Sep 18, 2017
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me

@xabbuh
Copy link
Member

xabbuh commented Sep 22, 2017

Thank you @Lctrs.

xabbuh added a commit that referenced this pull request Sep 22, 2017
…alizer (Lctrs)

This PR was squashed before being merged into the 3.4 branch (closes #8267).

Discussion
----------

[Serializer] Document the new DateIntervalNormalizer normalizer

Waiting for symfony/symfony#23747 to be merged.

Commits
-------

9784714 [Serializer] Document the new DateIntervalNormalizer normalizer
@xabbuh xabbuh closed this Sep 22, 2017
@Lctrs Lctrs deleted the feature/dateintervalnormalizer branch September 22, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants