[FrameworkBundle] Added doc for ControllerTrait::isFormValid #8518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing because the related proposal (symfony/symfony#24576) was closed without merging. |
|
Thanks for closing this PR. I forgot |
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jan 2, 2019
… (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] Added `ControllerTrait::isFormValid` | Q | A | ------------- | --- | Branch? | master (4.1) | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8518 Commits ------- 1a8c844f0e [FrameworkBundle] Added `ControllerTrait::isFormValid`
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 2, 2019
… (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] Added `ControllerTrait::isFormValid` | Q | A | ------------- | --- | Branch? | master (4.1) | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8518 Commits ------- 1a8c844 [FrameworkBundle] Added `ControllerTrait::isFormValid`
|
@javiereguiluz @lyrixx shouldn't this be reopened now as symfony/symfony#24576 was merged? |
|
@eXtreme You are right. I'm not able to re-open the PR. I will open a new one instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#24576