[Templating] Add the asset package requirement #8804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f82e4d2 to
47494ba
Compare
xabbuh
approved these changes
Dec 1, 2017
javiereguiluz
approved these changes
Dec 1, 2017
|
This is great! I also am sure we are still missing a few of these :). This also just inspired: symfony/symfony#25256. Of course the documentation needs to be correct. But indeed, it is a bad error. |
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was merged into the 4.0 branch. Discussion ---------- [Templating] Add the asset package requirement New comers will get an errors if they use the `asset()` Twig function without installing the `asset` package. This PR makes sure they won't get an "WTF" reaction to the error they would get ;) Commits ------- 47494ba Templating docs: add the asset package requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New comers will get an errors if they use the
asset()Twig function without installing theassetpackage.This PR makes sure they won't get an "WTF" reaction to the error they would get ;)