Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update collection.rst #8831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update collection.rst #8831

wants to merge 1 commit into from

Conversation

babaorum
Copy link
Contributor

@babaorum babaorum commented Dec 5, 2017

@babaorum
Copy link
Contributor Author

babaorum commented Dec 5, 2017

Sorry if some informations are missing, or it does not respect exactly your contributing conventions.
It is my first time contributing on this.

Please tell me if anything needs to be add / change.

@javiereguiluz
Copy link
Member

@babaorum thanks for fixing this and congrats on your first Symfony Docs contribution. You did it great, but I merged it on 3.3 branch because that's the oldest supported branch that this fix applies to. Thanks

javiereguiluz added a commit that referenced this pull request Jan 7, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.3 branch instead (closes #8831).

Discussion
----------

Update collection.rst

A default value is set and seems to work for the `entry_type` option.
https://github.com/symfony/symfony/blob/3ce9c29ae44692555d15983c7537187f5566e9ce/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php#L97

Commits
-------

5084ad1 Update collection.rst
xabbuh pushed a commit that referenced this pull request Jan 8, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.3 branch instead (closes #8831).

Discussion
----------

Update collection.rst

A default value is set and seems to work for the `entry_type` option.
https://github.com/symfony/symfony/blob/3ce9c29ae44692555d15983c7537187f5566e9ce/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php#L97

Commits
-------

5084ad1 Update collection.rst
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 10, 2018
* 2.8:
  minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [error_pages] Removing misleading  checker in code example
  add default option value for collection type
  minor symfony#8831 Update collection.rst (babaorum)
  Move JavaScript to seperate file
  Remove section about forms using validation
  Removed extra class
  Renamed TestedTypeTests to TestedTypeTest
  Add docs about the validator TypeTestCase class
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 10, 2018
* 2.8:
  minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [error_pages] Removing misleading  checker in code example
  add default option value for collection type
  minor symfony#8831 Update collection.rst (babaorum)
  Move JavaScript to seperate file
  Remove section about forms using validation
  Removed extra class
  Renamed TestedTypeTests to TestedTypeTest
  Add docs about the validator TypeTestCase class
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 10, 2018
* 3.3: (22 commits)
  add note about same-state transitions
  minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [error_pages] Removing misleading  checker in code example
  Updated LDAP documentation for Symfony 3.1
  Updating example README to match note below it
  Update docs for setting custom response code in exception handler
  add default option value for collection type
  minor symfony#8831 Update collection.rst (babaorum)
  minor symfony#8987 Fix YAML config bug (Holicz, javiereguiluz)
  Move JavaScript to seperate file
  Remove section about forms using validation
  Removed extra class
  Update fomr testing sentence
  Renamed TestedTypeTests to TestedTypeTest
  ...
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 10, 2018
* 3.4: (30 commits)
  add note about same-state transitions
  minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [Workflow] Document the new transition completed event
  [error_pages] Removing misleading  checker in code example
  fix syntax errors and add some more crosslinks
  Updated LDAP documentation for Symfony 3.1
  Updating example README to match note below it
  Update docs for setting custom response code in exception handler
  add default option value for collection type
  minor symfony#8831 Update collection.rst (babaorum)
  minor symfony#8987 Fix YAML config bug (Holicz, javiereguiluz)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants