Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clean up #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clean up #8944

wants to merge 2 commits into from

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Dec 31, 2017 •
edited
Loading

I've removed all white spaces and extra lines from our documentation 😄

javiereguiluz
javiereguiluz approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carusogabriel this is really nice! If you tell GitHub review to ignore white space changes (https://github.com/symfony/symfony-docs/pull/8944/files?w=1) it's easy to verify that all changes are correct 👍

I hope it's mergeable for our doc maintainers (sometimes these PRs with lots of minor changes everywhere are a nightmare to merge into upper branches).

@carusogabriel
Copy link
Contributor Author

carusogabriel commented Dec 31, 2017 •
edited
Loading

@javiereguiluz Thanks so much for this tip. I'll use it for bigger PRs that only trail whitespaces 😃

@wouterj
Copy link
Member

wouterj commented Dec 31, 2017

Love it! I assume you have a script for this? Can you please run it on the 2.8 branch, now that I merged up your PR? Then we can work together and get all currently maintained branches fixed :)

@wouterj wouterj closed this Dec 31, 2017
wouterj added a commit that referenced this pull request Dec 31, 2017
@wouterj
minor #8944 Clean up (carusogabriel)
d117184 
This PR was squashed before being merged into the 2.7 branch (closes #8944).

Discussion
----------

Clean up

I've removed all white spaces and extra lines from our documentation 😄

Commits
-------

63517b9 Remove extra lines
fc9e351 Trailing whitespaces
@carusogabriel carusogabriel deleted the clean-up branch December 31, 2017 11:16
@carusogabriel
Copy link
Contributor Author

@wouterj Sure, will be my pleasure. Open that PR in a minute 👨‍💻

@carusogabriel carusogabriel mentioned this pull request Dec 31, 2017
Closed
wouterj added a commit that referenced this pull request Dec 31, 2017
@wouterj
minor #8945 Clean up (carusogabriel)
51e7b68 
This PR was squashed before being merged into the 2.8 branch (closes #8945).

Discussion
----------

Clean up

Following #8944, suggested by @wouterj

Commits
-------

a63fd12 Clean up
@carusogabriel carusogabriel mentioned this pull request Jan 1, 2018
Closed
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Jan 2, 2018
@nicolas-grekas
minor #25652 Clean up (carusogabriel)
e577288 
This PR was squashed before being merged into the 2.7 branch (closes #25652).

Discussion
----------

Clean up

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I've removed all white spaces and extra lines from our `markdown` files. Recently [I did it in our documentation](symfony/symfony-docs#8944), and thought would be interesting to replicate here 😄

Commits
-------

acd0d7c Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carusogabriel @wouterj @javiereguiluz @carsonbot