Use symfony/skeleton to show the welcome page again #9333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you create the symfony/website-skeleton as suggested in the docs you won't see the welcome page as stated later on this page ("If everything is working, you'll see a welcome page") but a 404 error, because of the routes the profiler generates.
(see also https://stackoverflow.com/questions/48643561/symfony-4-setup-issues-router-exception/48647114#48647114)
Also on the 'next' page "Create your First Page in Symfony" the installation of the profiler is suggested which is already installed with the symfony/website-skeleton.
|
@PeterMarteau thanks for your first contribution to this repository. You are 100% correct about this. Using the skeleton instead of the website-skeleton would display the Welcome Page. However, that would "break" other things because in the docs we suppose that you are using the website-skeleton, so we'd need to change a lot of other things. The best solution to this is to always display the Welcome Page, no matter if you use the skeleton or website-skeleton. There's a pull request to fix that: symfony/symfony#26041 I'll try to finish it soon. That's why I'm closing this pull request and I hope you understand it. Also, we're looking forward to receive more contributions from you in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create the symfony/website-skeleton as suggested in the docs you won't see the welcome page as stated later on this page ("If everything is working, you'll see a welcome page") but a 404 error, because of the routes the profiler generates.
(see also https://stackoverflow.com/questions/48643561/symfony-4-setup-issues-router-exception/48647114#48647114)
Also on the 'next' page "Create your First Page in Symfony" the installation of the profiler is suggested which is already installed with the symfony/website-skeleton.