[Validator] Document the "normalizer" option #9433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
944efb7 to
27d13b3
Compare
ndench
reviewed
Oct 29, 2018
reference/constraints/NotBlank.rst
Outdated
|
|
||
| If ``true`` and if the given value is a ``string``, then the :phpfunction:`trim` | ||
| PHP function will be used in order to ignore leading and trailing whitespace | ||
| characters while checking if it is valid. |
There was a problem hiding this comment.
Why does the NotBlank constraint only have trim whereas all the others have ltrim and rtrim?
There was a problem hiding this comment.
These options were replaced by the normalizer option. The patch PR has changed a lot since it's creation so I'm waiting a bit more to update the docs.
fabpot
reviewed
Mar 31, 2019
reference/constraints/Uuid.rst
Outdated
| @@ -117,6 +117,7 @@ The following PHP constants can also be used: | |||
|
|
|||
| All five versions are allowed by default. | |||
|
|
|||
| .. include:: /reference/constraints/_ltrim-rtim-options.rst.inc | |||
There was a problem hiding this comment.
Typo in the file name -> should be rtrim, not rtim (to be fixed eveywhere :))
|
This PR does not describe the feature implemented in the related PR anymore, so it needs to be updated. |
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Mar 31, 2019
…sed validators (renan-taranto) This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] String normalization options for string-based validators | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26239 | License | MIT | Doc PR | symfony/symfony-docs#9433 Todo: - [x] Document the new options - [x] Update Doc PR Add trimming options to the string constraints. Commits ------- 708d759b8d [Validator] String normalization options for string-based validators
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 31, 2019
…sed validators (renan-taranto) This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] String normalization options for string-based validators | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26239 | License | MIT | Doc PR | symfony/symfony-docs#9433 Todo: - [x] Document the new options - [x] Update Doc PR Add trimming options to the string constraints. Commits ------- 708d759 [Validator] String normalization options for string-based validators
OskarStark
reviewed
Mar 31, 2019
reference/constraints/Email.rst
Outdated
| @@ -144,6 +144,7 @@ If true, then the :phpfunction:`checkdnsrr` PHP function will be used to | |||
| check the validity of the MX *or* the A *or* the AAAA record of the host | |||
| of the given email. | |||
|
|
|||
| .. include:: /reference/constraints/_ltrim-rtim-options.rst.inc | |||
There was a problem hiding this comment.
I would prefer 2 files:
/reference/constraints/_ltrim-option.rst.inc
and
/reference/constraints/_rtrim-option.rst.inc
Indeed. I will update it. |
e40e98b to
6eec07b
Compare
|
The |
|
You are right, I removed the label 👍🏻 |
javiereguiluz
added a commit
that referenced
this pull request
Apr 24, 2019
This PR was merged into the master branch. Discussion ---------- [Validator] Document the "normalizer" option Documents the PR symfony/symfony#26484 Commits ------- 6eec07b [Validator] Document the "normalizer" option
|
Renan, thanks for providing the docs for this feature! Also, congrats on your first Symfony Docs contribution! |
|
Hi, @javiereguiluz, thanks! I'm glad to contribute to symfony code and docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the PR symfony/symfony#26484