Documented the trailing_slash_on_root option #9490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routing/external_resources.rst
Outdated
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; | ||
|
|
||
| /** | ||
| * @Route("/site", "trailing_slash_on_root"="false") |
There was a problem hiding this comment.
this does not work on annotations: trailing_slash_on_root works only as an import option.
routing/external_resources.rst
Outdated
| use Symfony\Component\Routing\RouteCollection; | ||
|
|
||
| $app = $loader->import('../src/Controller/', 'annotation'); | ||
| // the second argument is the $trailing_slash_on_root option |
There was a problem hiding this comment.
the argument is named $trailingSlashOnRoot in PHP, for what it matters :)
nicolas-grekas
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9484.
@nicolas-grekas could you please verify if the config of the example is correct? I don't know if
trailing_slash_on_rootis defined for annotations. Thanks!