[LDAP] Add docs for applyOperations method #9715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
symfony-splitter
pushed a commit
to symfony/ldap
that referenced
this pull request
May 18, 2018
…ablae) This PR was merged into the 4.2-dev branch. Discussion ---------- [LDAP] Add "applyOperations" method to EntryManager | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27039 | License | MIT | Doc PR | symfony/symfony-docs#9715 This PR adds a new method called `applyOperations` to the LDAP `EntryManager` class. Internally it is mapping the new `UpdateOperation` object to the `ldap_modify_batch` method. Tests green against openldap. Thanks for any feedback. Todo: * [x] Add Docs PR Commits ------- 8fc09c73c6 Add applyOperations batch method to EntryManager
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 18, 2018
…ablae) This PR was merged into the 4.2-dev branch. Discussion ---------- [LDAP] Add "applyOperations" method to EntryManager | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27039 | License | MIT | Doc PR | symfony/symfony-docs#9715 This PR adds a new method called `applyOperations` to the LDAP `EntryManager` class. Internally it is mapping the new `UpdateOperation` object to the `ldap_modify_batch` method. Tests green against openldap. Thanks for any feedback. Todo: * [x] Add Docs PR Commits ------- 8fc09c7 Add applyOperations batch method to EntryManager
xabbuh
reviewed
May 18, 2018
components/ldap.rst
Outdated
|
|
||
| Use the EntryManager's ``applyOperations()`` method to update multiple attributes at once:: | ||
|
|
||
|
|
xabbuh
reviewed
May 18, 2018
components/ldap.rst
Outdated
| Batch Updating | ||
| ______________ | ||
|
|
||
| Use the EntryManager's ``applyOperations()`` method to update multiple attributes at once:: |
There was a problem hiding this comment.
and we could use the method role here:
:method:`Symfony\\Component\\Ldap\\Adapter\\ExtLdap\\EntryManager::applyOperations`
xabbuh
reviewed
May 18, 2018
components/ldap.rst
Outdated
| new UpdateOpteration(LDAP_MODIFY_BATCH_ADD, 'mail', '[email protected]'), | ||
| )); | ||
|
|
||
| Possible operation types are ``LDAP_MODIFY_BATCH_ADD``, ``LDAP_MODIFY_BATCH_REMOVE``, ``LDAP_MODIFY_BATCH_REMOVE_ALL``, ``LDAP_MODIFY_BATCH_REPLACE``. Parameter ``$values`` must be ``NULL`` when using ``LDAP_MODIFY_BATCH_REMOVE_ALL`` operation type. |
There was a problem hiding this comment.
we usually split lines after the first word that crosses the 72nd character
xabbuh
reviewed
May 18, 2018
components/ldap.rst
Outdated
| Possible operation types are ``LDAP_MODIFY_BATCH_ADD``, ``LDAP_MODIFY_BATCH_REMOVE``, ``LDAP_MODIFY_BATCH_REMOVE_ALL``, ``LDAP_MODIFY_BATCH_REPLACE``. Parameter ``$values`` must be ``NULL`` when using ``LDAP_MODIFY_BATCH_REMOVE_ALL`` operation type. | ||
|
|
||
| .. versionadded:: 4.2 | ||
| The ``applyOperations()`` was introduced in Symfony 4.2. |
There was a problem hiding this comment.
The applyOperations() method [...]
|
Thanks @xabbuh . I just applied your fixes and rebased it. |
xabbuh
approved these changes
May 19, 2018
|
Malte, thanks for contributing this feature to Symfony and for providing the docs for it. Also, it was the first Symfony Docs contribution, so thank you and congrats! |
javiereguiluz
added a commit
that referenced
this pull request
May 22, 2018
This PR was merged into the master branch. Discussion ---------- [LDAP] Add docs for applyOperations method See PR symfony/symfony#27069 Commits ------- 74fed75 [LDAP] Add docs for applyOperations method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR symfony/symfony#27069