Add mandatory method and attribute #9724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without $roles, construct(), getRoles() and eraseCredentials(), this entity doesn't work because of his interface It may be nice to add these methods so that you do not have any errors when you copy paste
doctrine/registration_form.rst
Outdated
|
|
||
| public function eraseCredentials() | ||
| { | ||
| } | ||
|
|
||
| // other methods, including security methods like getRoles() |
There was a problem hiding this comment.
If we make these changes, we'll need to reword or remove this comment too:
// other methods, including security methods like getRoles()
Thanks!
20uf
approved these changes
May 6, 2018
javiereguiluz
approved these changes
May 7, 2018
|
Thanks Thomas. This was a nice first contribution to Symfony Docs! |
javiereguiluz
added a commit
that referenced
this pull request
May 9, 2018
This PR was squashed before being merged into the 2.7 branch (closes #9724). Discussion ---------- Add mandatory method and attribute For the page "Implement a Simple Registration Form" Without $roles, construct(), getRoles() and eraseCredentials(), this entity doesn't work because of his interface It may be nice to add these methods so that you do not have any errors when you copy paste Commits ------- 9ddb69d Add mandatory method and attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the page "Implement a Simple Registration Form"
Without $roles, construct(), getRoles() and eraseCredentials(), this entity doesn't work because of his interface
It may be nice to add these methods so that you do not have any errors when you copy paste