[Console] Fix SymfonyStyle::ask usage #9741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use function "ctype_digit" instead of "is_integer" because "$number" is not an integer value, but a string
xabbuh
reviewed
May 8, 2018
console/style.rst
Outdated
| @@ -238,7 +238,7 @@ User Input Methods | |||
| the third argument:: | |||
|
|
|||
| $io->ask('Number of workers to start', 1, function ($number) { | |||
| if (!is_integer($number)) { | |||
| if (!ctype_digit($number)) { | |||
There was a problem hiding this comment.
Won't this fail if the user types nothing and the default value (which actually is an integer) is used? What about combining both checks?
There was a problem hiding this comment.
Could we use http://php.net/is_numeric first and then cast to int?
|
Thanks Liviu for reporting this bug! I finally changed the code to use is_numeric() and a (int) cast. |
javiereguiluz
added a commit
that referenced
this pull request
May 15, 2018
…eguiluz) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix SymfonyStyle::ask usage Use function "ctype_digit" instead of "is_integer" because "$number" is not an integer value, but a string <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 9bb23e1 Use is_numeric() 38bcfcb [Console] Fix SymfonyStyle::ask usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use function "ctype_digit" instead of "is_integer" because "$number" is not an integer value, but a string