[DoctrineBridge] update doctrine event listeners doc for Symfony 4.2 change #9973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
symfony-splitter
pushed a commit
to symfony/doctrine-bridge
that referenced
this pull request
Jun 28, 2018
…ServiceLocator (dmaicher) This PR was squashed before being merged into the 4.2-dev branch (closes #27675). Discussion ---------- [DoctrineBridge] always load event listeners lazy via ServiceLocator | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes/no | Tests pass? | yes | Fixed tickets | symfony/symfony#27661 | License | MIT | Doc PR | symfony/symfony-docs#9973 As described in symfony/symfony#27661 this PR suggests to always load doctrine event listeners lazily from a service locator instead of the full service container. If we agree to move forward I could tackle the remaining todos: - [x] update UPGRADE.md - [x] documentation PR - [x] tested on real app Commits ------- 130ec0525d [DoctrineBridge] always load event listeners lazy via ServiceLocator
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 28, 2018
…ServiceLocator (dmaicher) This PR was squashed before being merged into the 4.2-dev branch (closes #27675). Discussion ---------- [DoctrineBridge] always load event listeners lazy via ServiceLocator | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes/no | Tests pass? | yes | Fixed tickets | #27661 | License | MIT | Doc PR | symfony/symfony-docs#9973 As described in #27661 this PR suggests to always load doctrine event listeners lazily from a service locator instead of the full service container. If we agree to move forward I could tackle the remaining todos: - [x] update UPGRADE.md - [x] documentation PR - [x] tested on real app Commits ------- 130ec05 [DoctrineBridge] always load event listeners lazy via ServiceLocator
HeahDude
reviewed
Jun 28, 2018
|
|
||
| .. _`The Event System`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html | ||
| .. _`the Doctrine Documentation`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html#entity-listeners | ||
| So whenever possible it is preferable to use entity listeners instead of subscribers. |
There was a problem hiding this comment.
Hmm we might need another PR in core before merging such thing x).
dmaicher
commented
Jun 28, 2018
| whenever possible. | ||
|
|
||
| .. versionadded:: 4.2 | ||
| The default lazy behavior of Doctrine entity listeners was introduced in |
There was a problem hiding this comment.
technically this is not correct. It was possible even before Symfony 4.2 but you had to manually add a 😊lazy=true attribute for the tag. Now since 4.2 it will be always lazy
There was a problem hiding this comment.
Ah sorry I missed the "default" while reading it. All good 👍
There was a problem hiding this comment.
In that phrase I tried to say: "in 4.2 the new thing is that is lazy by default". But it looks like I failed.
There was a problem hiding this comment.
@dmaicher in 4.2 they are lazy by default ... or are they mandatory lazy? In other words, can you say lazy:false in 4.2?
There was a problem hiding this comment.
No they are always lazy now. So mandatory.
dmaicher
commented
Jun 29, 2018
| @@ -198,4 +198,5 @@ That's why it is preferable to use entity listeners instead of subscribers | |||
| whenever possible. | |||
|
|
|||
| .. versionadded:: 4.2 | |||
| Starting from Symfony 4.2, Doctrine entity listeners are lazy by default. | |||
| Starting from Symfony 4.2, Doctrine entity listeners are always lazy. In | |||
There was a problem hiding this comment.
I think now its more clear 👍 Thanks 😄
|
Thanks David. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 29, 2018
…Symfony 4.2 change (dmaicher, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [DoctrineBridge] update doctrine event listeners doc for Symfony 4.2 change See symfony/symfony#27675. Doctrine entity listeners are always lazily instantiated as of Symfony 4.2. Commits ------- 4409fd6 Explain that lazy listeners are mandatory, not default b56ef9e Update event_listeners_subscribers.rst d8bb849 Reworded and added the versionadded directive 601450e Update event_listeners_subscribers.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#27675.
Doctrine entity listeners are always lazily instantiated as of Symfony 4.2.