This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Check that the system has the PHP version required by Symfony #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will now have to skip some tests when on PHP 5.4. |
|
This is now ready for the final review. Thanks! |
| */ | ||
| public function testSymfonyRequiresNewerPhpVersion() | ||
| { | ||
| if (version_compare(phpversion(), '5.5.0', '>=')) { |
|
Should we make it possible to skip the version check to be able to bootstrap a project even on a system that isn't fully ready to run the application itself? |
|
@xabbuh I'd prefer to keep failing if your system is not ready to run the Symfony version you want to install. |
|
I think this needs more work. If you don't pass any version, you are using |
|
This is now ready for a new review. I changed everything about how we decide if a version is installable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #239.