Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

always show an error message with PHP < 5.4 #66

Merged
merged 1 commit into from
Dec 4, 2014
Merged

always show an error message with PHP < 5.4 #66

merged 1 commit into from
Dec 4, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 3, 2014

No description provided.

@xabbuh xabbuh mentioned this pull request Dec 3, 2014
Merged
@1ed
Copy link
Contributor

1ed commented Dec 3, 2014

👍 works well for me

$ php symfony.phar 
Symfony Installer requires PHP 5.4 version or higher and your system has
PHP 5.3.3 version installed.

To solve this issue, upgrade your PHP installation or install Symfony manually
executing the following command:

composer create-project symfony/framework-standard-edition <project-name> <symfony-version>

@1ed
Copy link
Contributor

1ed commented Dec 3, 2014

Maybe you should remove the other check in the command.

1ed
1ed reviewed Dec 3, 2014
View reviewed changes
symfony
PHP_VERSION
));

return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe exit(1) here?

@xabbuh xabbuh force-pushed the php-version-error branch from f73b7fb to 33e3b01 Compare December 3, 2014 17:08
@xabbuh xabbuh force-pushed the php-version-error branch from 33e3b01 to 279cf17 Compare December 3, 2014 17:10
@xabbuh
Copy link
Member Author

xabbuh commented Dec 3, 2014

@1ed Thanks for the feedback.

@fabpot
Copy link
Member

fabpot commented Dec 4, 2014

Thank you @xabbuh.

@fabpot fabpot merged commit 279cf17 into symfony:master Dec 4, 2014
fabpot added a commit that referenced this pull request Dec 4, 2014
@fabpot
minor #66 always show an error message with PHP < 5.4 (xabbuh)
581df76 
This PR was merged into the 1.0-dev branch.

Discussion
----------

always show an error message with PHP < 5.4

Commits
-------

279cf17 always show an error message with PHP < 5.4
@xabbuh xabbuh deleted the php-version-error branch December 4, 2014 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @1ed @fabpot